Summary

Modernize reviewboard.hostingsvcs.base.forms.

Review Request #13184 — Created Aug. 3, 2023 and submitted Aug. 7, 2023, 8:14 p.m.

Owner

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Groups

People

Description

This adds typing and documentation for the hosting service form code,
and removes some legacy Python 2-isms for string types and keyword
arguments.

Testing Done

All unit tests pass.

Commits

Summary	ID
Modernize reviewboard.hostingsvcs.base.forms. This adds typing and documentation for the hosting service form code, and removes some legacy Python 2-isms for string types and keyword arguments.	fb5c6d0fa0193b9619a8fd8e51a16da69db15062

Issues

Description	From	Last Updated
Shouldn't this be a class type instead of instance?	david	Aug. 7, 2023, 8:02 p.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/base/forms.py (Diff revision 1)
Show all issues
```
Shouldn't this be a class type instead of instance?
```

Fixed an incorrect type in docs.

	Summary	ID
	Modernize reviewboard.hostingsvcs.base.forms. This adds typing and documentation for the hosting service form code, and removes some legacy Python 2-isms for string types and keyword arguments.	1566812f21ea5b6bba3ee35280b0347d9a10d6d6
	Modernize reviewboard.hostingsvcs.base.forms. This adds typing and documentation for the hosting service form code, and removes some legacy Python 2-isms for string types and keyword arguments.	fb5c6d0fa0193b9619a8fd8e51a16da69db15062

Revision 2 (+232 -120)

flake8 passed.

JSHint passed.

Ship it!

Pushed to release-6.x (81e0f64)