Modernize reviewboard.hostingsvcs.base.paginator.

 






 

 


  Review Request #13182
  —
  Created Aug. 2, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This adds typing and docs to the hosting service paginator code, helping

implementations return the correct results from paginators. It also adds

some assertions to help ensure some state is set correctly when

accessed.


The paginators are generics, allowing the page data type and item types

to be provided to help with consuming expected values in a type-safe

way.

 








  


 
 

  
All unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Modernize reviewboard.hostingsvcs.base.paginator.
     
This adds typing and docs to the hosting service paginator code, helping
implementations return the correct results from paginators. It also adds
some assertions to help ensure some state is set correctly when
accessed.

The paginators are generics, allowing the page data type and item types
to be provided to help with consuming expected values in a type-safe
way.

    

   
  		
  bfde81ecf2a444a70a7f70519300ce45f8680267
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/base/paginator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...