Modernize reviewboard.hostingsvcs.base.paginator.

Review Request #13182 — Created Aug. 2, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This adds typing and docs to the hosting service paginator code, helping
implementations return the correct results from paginators. It also adds
some assertions to help ensure some state is set correctly when
accessed.

The paginators are generics, allowing the page data type and item types
to be provided to help with consuming expected values in a type-safe
way.

All unit tests pass.

Summary ID
Modernize reviewboard.hostingsvcs.base.paginator.
This adds typing and docs to the hosting service paginator code, helping implementations return the correct results from paginators. It also adds some assertions to help ensure some state is set correctly when accessed. The paginators are generics, allowing the page data type and item types to be provided to help with consuming expected values in a type-safe way.
a991eff59000a70a8edad235300dd1f7a8dbd5b8
Description From Last Updated

'typing.Dict' imported but unused Column: 1 Error code: F401

reviewbotreviewbot

'typing.Iterable' imported but unused Column: 1 Error code: F401

reviewbotreviewbot

'typing.cast' imported but unused Column: 1 Error code: F401

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (0d7e59c)