Summary

Modernize reviewboard.hostingsvcs.base.paginator.

Review Request #13182 — Created Aug. 2, 2023 and submitted Aug. 7, 2023, 1:02 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This adds typing and docs to the hosting service paginator code, helping

implementations return the correct results from paginators. It also adds

some assertions to help ensure some state is set correctly when

accessed.
The paginators are generics, allowing the page data type and item types

to be provided to help with consuming expected values in a type-safe

way.

Testing Done

All unit tests pass.

Commits

Summary	ID
Modernize reviewboard.hostingsvcs.base.paginator. This adds typing and docs to the hosting service paginator code, helping implementations return the correct results from paginators. It also adds some assertions to help ensure some state is set correctly when accessed. The paginators are generics, allowing the page data type and item types to be provided to help with consuming expected values in a type-safe way.	a991eff59000a70a8edad235300dd1f7a8dbd5b8

Summary

Modernize reviewboard.hostingsvcs.base.paginator.

This adds typing and docs to the hosting service paginator code, helping implementations return the correct results from paginators. It also adds some assertions to help ensure some state is set correctly when accessed. The paginators are generics, allowing the page data type and item types to be provided to help with consuming expected values in a type-safe way.

a991eff59000a70a8edad235300dd1f7a8dbd5b8

Issues

Description	From	Last Updated
'typing.Dict' imported but unused Column: 1 Error code: F401	reviewbot	Aug. 2, 2023, 4:42 p.m.
'typing.Iterable' imported but unused Column: 1 Error code: F401	reviewbot	Aug. 2, 2023, 4:42 p.m.
'typing.cast' imported but unused Column: 1 Error code: F401	reviewbot	Aug. 2, 2023, 4:42 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/base/paginator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Dict' imported but unused

Column: 1
Error code: F401
```
reviewboard/hostingsvcs/base/paginator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Iterable' imported but unused

Column: 1
Error code: F401
```
reviewboard/hostingsvcs/base/paginator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.cast' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Modernize reviewboard.hostingsvcs.base.paginator. This adds typing and docs to the hosting service paginator code, helping implementations return the correct results from paginators. It also adds some assertions to help ensure some state is set correctly when accessed. The paginators are generics, allowing the page data type and item types to be provided to help with consuming expected values in a type-safe way.	bfde81ecf2a444a70a7f70519300ce45f8680267
	Modernize reviewboard.hostingsvcs.base.paginator. This adds typing and docs to the hosting service paginator code, helping implementations return the correct results from paginators. It also adds some assertions to help ensure some state is set correctly when accessed. The paginators are generics, allowing the page data type and item types to be provided to help with consuming expected values in a type-safe way.	a991eff59000a70a8edad235300dd1f7a8dbd5b8

Diff:

Revision 2 (+662 -248)

Show changes

reviewboard/hostingsvcs/base/paginator.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (0d7e59c)