• 
      

    Modernize hosting service registry management.

    Review Request #13181 — Created Aug. 2, 2023 and submitted

    Information

    Review Board
    release-6.x

    Reviewers

    This makes a handful of changes for the hosting service registry, adding
    typing, new documentation, and utility methods designed to replace those
    in reviewboard.hostingsvcs.service.

    HostingServiceRegistry now has convenience methods for retrieving or
    unregistering a hosting service by ID. Logging from the methods in
    service.py have also been added. With this, the service.py code is
    now just a thin wrapper over the registry.

    Pre-population of the registry via the initializing signal now happens
    within reviewboard/hostingsvcs/__init__.py, which is guaranteed to be
    run. It no longer relies on service.py being imported somewhere.

    All unit tests pass.

    Summary ID
    Modernize hosting service registry management.
    This makes a handful of changes for the hosting service registry, adding typing, new documentation, and utility methods designed to replace those in `reviewboard.hostingsvcs.service`. `HostingServiceRegistry` now has convenience methods for retrieving or unregistering a hosting service by ID. Logging from the methods in `service.py` have also been added. With this, the `service.py` code is now just a thin wrapper over the registry. Pre-population of the registry via the `initializing` signal now happens within `reviewboard/hostingsvcs/__init__.py`, which is guaranteed to be run. It no longer relies on `service.py` being imported somewhere.
    88dfddc3c7e505d693fc158c4f02ba0df3d5941f
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-6.x (5261cde)