flake8
passed.
JSHint
passed.
Review Request #13181 — Created Aug. 2, 2023 and submitted
This makes a handful of changes for the hosting service registry, adding
typing, new documentation, and utility methods designed to replace those
inreviewboard.hostingsvcs.service
.
HostingServiceRegistry
now has convenience methods for retrieving or
unregistering a hosting service by ID. Logging from the methods in
service.py
have also been added. With this, theservice.py
code is
now just a thin wrapper over the registry.Pre-population of the registry via the
initializing
signal now happens
withinreviewboard/hostingsvcs/__init__.py
, which is guaranteed to be
run. It no longer relies onservice.py
being imported somewhere.
All unit tests pass.
Summary | ID |
---|---|
88dfddc3c7e505d693fc158c4f02ba0df3d5941f |