Port FileAttachment, DraftFileAttachment models and DraftResourceChildModelMixin to TS/spina.
Review Request #13180 — Created Aug. 1, 2023 and submitted — Latest diff uploaded
This ports the file attachment and draft file attachment models to TypeScript
and spina. We enable extra data support on the models, which we don't use
for any particular reason right now but might need to use in the future. This
also ports the draft resource child model mixin to TypeScript/spina.
- Tested uploading new file attachments.
- Tested dragging and dropping to upload new file attachments.
- Tested viewing file attachments.
- Saw that published file attachments appear correctly.
- Tested dragging and dropping an image file into a review reply.
- Tested deleting file attachments.
- Tested updating file attachments.
- Tested posting review request drafts with file attachments.
- Ran JS unit tests.
Changes between revision 2 and 3
orig
1
2
3
4
5
6
Commits
Files
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/js/common/resources/index.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/baseResource.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts |
|---|
| reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js |
|---|
| reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts |
|---|
| reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.es6.js |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/index.ts |
|---|
| reviewboard/static/rb/js/resources/models/draftFileAttachmentModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js |
|---|
| reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts |
|---|
| reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts |
|---|
| reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts |
|---|
| reviewboard/static/rb/js/views/uploadAttachmentView.es6.js |
|---|