Summary:

Port FileAttachment, DraftFileAttachment models and DraftResourceChildModelMixin to TS/spina.

Review Request #13180 — Created Aug. 1, 2023 and submitted Aug. 7, 2023, 10:33 a.m.

Information
Owner:	maubin
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This ports the file attachment and draft file attachment models to TypeScript
and spina. We enable extra data support on the models, which we don't use
for any particular reason right now but might need to use in the future. This
also ports the draft resource child model mixin to TypeScript/spina.

Testing Done


Tested uploading new file attachments.
Tested dragging and dropping to upload new file attachments.
Tested viewing file attachments.
Saw that published file attachments appear correctly.
Tested dragging and dropping an image file into a review reply.
Tested deleting file attachments.
Tested updating file attachments.
Tested posting review request drafts with file attachments.
Ran JS unit tests.

Commits

Summary
	Port FileAttachment, DraftFileAttachment models and

Screenshots

Issues

Description	From	Last Updated
Missing semicolon. Column: 69 Error code: W033	reviewbot	Aug. 3, 2023, 3:22 p.m.
Missing semicolon. Column: 43 Error code: W033	reviewbot	Aug. 3, 2023, 3:22 p.m.
Add a blank line in here.	david	Aug. 4, 2023, 2:15 p.m.
The only thing necessary here should be rspNamespace.	david	Aug. 4, 2023, 2:22 p.m.
Add a blank line in here.	david	Aug. 4, 2023, 2:16 p.m.
This needs a doc comment.	david	Aug. 4, 2023, 2:18 p.m.
Add a blank line in here.	david	Aug. 4, 2023, 2:18 p.m.
This file should be deleted.	david	Aug. 4, 2023, 2:15 p.m.
This needs a trailing comma.	david	Aug. 4, 2023, 2:19 p.m.
This needs a trailing comma.	david	Aug. 4, 2023, 2:19 p.m.
.. before .	david	Aug. 7, 2023, 10:06 a.m.
This should use single quotes.	david	Aug. 7, 2023, 10:07 a.m.

flake8 passed.

JSHint passed.

Summary:

-	Port FileAttachment model to spina and Typescript.
+	[WIP] Port FileAttachment model to spina and Typescript.

Change Summary:


Ported DraftFileAttachmentModel and DraftResourceChildModelMixin too

Commits:

	Summary
-	Port FileAttachment model to spina and Typescript.
+	Port FileAttachment model to spina and Typescript.

Diff:

Revision 2 (+666 -200)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResource.ts
	reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/draftFileAttachmentModel.es6.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js
	5 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js (Diff revision 2)
Show all issues
```
Missing semicolon.

Column: 69
Error code: W033
```
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
Show all issues
```
Missing semicolon.

Column: 43
Error code: W033
```

Summary:

-	[WIP] Port FileAttachment model to spina and Typescript.
+	Port FileAttachment, DraftFileAttachment models and DraftResourceChildModelMixin to TS/spina.

Description:

~		Port FileAttachment model to spina and Typescript.
	~	This ports the file attachment and draft file attachment models to TypeScript
	+	and spina. We enable extra data support on the models, which we don't use
	+	for any particular reason right now but might need to use in the future. This
	+	also ports the draft resource child model mixin to TypeScript/spina.

Testing Done:

	+	Tested uploading new file attachments.
	+	Tested dragging and dropping to upload new file attachments.
	+	Tested viewing file attachments.
	+	Saw that published file attachments appear correctly.
	+	Tested dragging and dropping an image file into a review reply.
	+	Tested deleting file attachments.
	+	Tested updating file attachments.
	+	Tested posting review request drafts with file attachments.
	+	Ran JS unit tests.

Commits:

	Summary
-	Port FileAttachment model to spina and Typescript.
+	Port FileAttachment model to spina and Typescript.

Diff:

Revision 3 (+560 -220)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looks great! I've got a handful of comments but they're all pretty tiny things.

reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts (Diff revision 3)
Show all issues
```
Add a blank line in here.
```

reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts (Diff revision 3)

Show all issues

The only thing necessary here should be rspNamespace.

reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts (Diff revision 3)
Show all issues
```
Add a blank line in here.
```
reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts (Diff revision 3)
Show all issues
```
This needs a doc comment.
```
reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts (Diff revision 3)
Show all issues
```
Add a blank line in here.
```
reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js (Diff revision 3)
Show all issues
```
This file should be deleted.
```
reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts (Diff revision 3)
Show all issues
```
This needs a trailing comma.
```
reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts (Diff revision 3)
Show all issues
```
This needs a trailing comma.
```

Commits:

	Summary
-	Port FileAttachment model to spina and Typescript.
+	Port FileAttachment model to spina and Typescript.

Diff:

Revision 4 (+418 -230)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

This looks basically ready to go. I just landed the change to fix up imports, so you'll probably need to fix a few conflicts when rebasing.

maubin Aug. 7, 2023, 9:27 a.m.
```
Got it.
```

Change Summary:


Rebased and made sure all the imports were good.

Commits:

	Summary
-		Port FileAttachment model to spina and Typescript.
+		Port FileAttachment, DraftFileAttachment models and

Diff:

Revision 5 (+406 -226)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts (Diff revision 5)
Show all issues
```
.. before .
```
reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts (Diff revision 5)
Show all issues
```
This should use single quotes.
```

Commits:

	Summary
-		Port FileAttachment, DraftFileAttachment models and
+		Port FileAttachment, DraftFileAttachment models and

Diff:

Revision 6 (+406 -226)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
	reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (dda0d5f)