Port FileAttachment, DraftFileAttachment models and DraftResourceChildModelMixin to TS/spina.

Review Request #13180 — Created Aug. 1, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This ports the file attachment and draft file attachment models to TypeScript
and spina. We enable extra data support on the models, which we don't use
for any particular reason right now but might need to use in the future. This
also ports the draft resource child model mixin to TypeScript/spina.

  • Tested uploading new file attachments.
  • Tested dragging and dropping to upload new file attachments.
  • Tested viewing file attachments.
  • Saw that published file attachments appear correctly.
  • Tested dragging and dropping an image file into a review reply.
  • Tested deleting file attachments.
  • Tested updating file attachments.
  • Tested posting review request drafts with file attachments.
  • Ran JS unit tests.
Summary ID
Port FileAttachment, DraftFileAttachment models and
DraftResourceChildModelMixin to TS/spina.
851273350e7d619d3c93af61de55c9dab7fb6eb0
Description From Last Updated

Missing semicolon. Column: 69 Error code: W033

reviewbotreviewbot

Missing semicolon. Column: 43 Error code: W033

reviewbotreviewbot

Add a blank line in here.

daviddavid

The only thing necessary here should be rspNamespace.

daviddavid

Add a blank line in here.

daviddavid

This needs a doc comment.

daviddavid

Add a blank line in here.

daviddavid

This file should be deleted.

daviddavid

This needs a trailing comma.

daviddavid

This needs a trailing comma.

daviddavid

.. before .

daviddavid

This should use single quotes.

daviddavid
maubin
maubin
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

maubin
david
  1. Looks great! I've got a handful of comments but they're all pretty tiny things.

  2. The only thing necessary here should be rspNamespace.

  3. This file should be deleted.

  4. This needs a trailing comma.

  5. This needs a trailing comma.

  6. 
      
maubin
david
  1. This looks basically ready to go. I just landed the change to fix up imports, so you'll probably need to fix a few conflicts when rebasing.

  2. 
      
maubin
david
maubin
maubin
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (dda0d5f)
Loading...