Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Modernize reviewboard.hostingsvcs.base.http and add typing.
Review Request #13177 — Created Aug. 1, 2023 and submitted
This updates the typing for the hosting service HTTP support, updating
some legacy documentation and bad assumptions in the code accordingly.
This includes the removal of a lot of Python 2-isms in the code and
documentation that are no longer needed.Functionality marked as deprecated in Review Board 4 have now been given
a deprecation warning, scheduled for removal in Review Board 7.
Unit tests pass.
Verified that pyright and mypy were happy with this module.
| Summary | ID |
|---|---|
| b23e45e8c69aa669989eaeef80a29b33a1051480 |
Review request changed
- Change Summary:
-
Added a type alias for query argument dictionaries, and changed values to
Any. - Commits:
-
Summary ID 2740cb59ed14e40fbb4c796fb6edeeac967412ab b23e45e8c69aa669989eaeef80a29b33a1051480 - Diff:
-
Revision 2 (+526 -194)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
