flake8
passed.
JSHint
passed.
Add the tips carousel to the review dialog.
Review Request #13173 — Created Aug. 1, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
With the change to pop up the review dialog as soon as a user clicks
"Create a new review", I worry that we're exacerbating the problem we've
always had of users not knowing how to create comments. This change adds
a new carousel of tips to the bottom of the review dialog, explaining
how to use comments and reviews.
Opened the review dialog for both empty and non-empty reviews. Saw that
when the review was empty, I saw the tips. The tips carousel starts in
auto-cycle mode, and I was able to cycle forward and backward through
the list.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Do you think some users would get annoyed of the tips carousel? I feel like I might after a while. … |
 maubin
|
|
|
I feel like this might look nice within an info alert. How does this look at the top of the … |
 chipx86
|
|
|
These lines are too long. The _ template literal will happily wrap and condense whitespace. |
chipx86
|
|
|
I think it'd be nice to add something like this: "For more information on reviewing code and documents, visit our … |
maubin
|
|
|
Missing localization. |
chipx86
|
|
|
Let's dedent this. No need to preserve the extra whitespace in the generated bundle. |
chipx86
|
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) I feel like this could use (a lot) more content. Please let me know if you have any ideas.
-
-
I feel like this might look nice within an info alert.
How does this look at the top of the dialog? That feels like a more stable location.
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) These lines are too long. The
_template literal will happily wrap and condense whitespace. -
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) Let's
dedentthis. No need to preserve the extra whitespace in the generated bundle.
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) I think it'd be nice to add something like this:
"For more information on reviewing code and documents, visit our documentation."
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+216 -4) |
|||||||||
Added Files: |
||||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Do you think some users would get annoyed of the tips carousel? I feel like I might after a while. We could add an X in the top right corner so that users can minimize the info alert, and when minimized it becomes just a "Show tips" link that they can click on to expand the full tips carousel again. And have this preference saved between reviews.