Summary

Add padding to size calculation for modal box contents.

Review Request #13172 — Created Aug. 1, 2023 and submitted Aug. 2, 2023, 9:47 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The review dialog in Review Board has had a long-standing bug where the
buttons could overlap with the dialog contents. This was due to the size
calculation including margin but not padding for the modal box contents.
This change adds that.

Testing Done

Verified that the dialog contents no longer overlapped the buttons.

Commits

Summary	ID
Add padding to size calculation for modal box contents. The review dialog in Review Board has had a long-standing bug where the buttons could overlap with the dialog contents. This was due to the size calculation including margin but not padding for the modal box contents. This change adds that. Testing Done: Verified that the dialog contents no longer overlapped the buttons.	a47945a032f95e1af719c10b8a67d553c82d66e4

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (0abeed8)