Port RB.Review to TS/spina

Review Request #13169 — Created Aug. 1, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports the Review model to TypeScript and spina.

Ran unit tests.

Summary ID
Port RB.Review to TS/spina
This change ports the Review model to TypeScript and spina. Testing Done: Ran unit tests.
366dd8c99365bb495a15c577fcc00b3d39565757
Description From Last Updated

Missing docs.

chipx86chipx86

Since these prototypeAttrs are already set on BaseResource, I thought we didn't have to include this here because they get …

maubinmaubin
chipx86
  1. 
      
  2. reviewboard/static/rb/js/common/resources/models/reviewModel.ts (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    Missing docs.

    1. So I'm a little conflicted here. I feel like it's useful to have this interface for type checking of parse methods, but it's not part of the API surface of the model. The items here also are completely duplicated by our webapi documentation and overlap almost 100% with the docs for the model attributes.

    2. Yeah, I get those arguments for sure. I guess given that these are API data (which I wasn't really thinking about when I wrote this), we can make an exception.

  3. 
      
maubin
  1. 
      
  2. reviewboard/static/rb/js/common/resources/models/reviewModel.ts (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    Since these prototypeAttrs are already set on BaseResource, I thought we didn't have to include this here because they get inherited?

    1. They're supposed to, but David's noticed a bug in Spina preventing this from working. I haven't worked it out yet.

    2. Oh got it.

  3. 
      
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (15e9e30)
Loading...