Summary

Port RB.Review to TS/spina

Review Request #13169 — Created Aug. 1, 2023 and submitted Aug. 7, 2023, 9:19 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the Review model to TypeScript and spina.

Testing Done

Ran unit tests.

Commits

Summary	ID
Port RB.Review to TS/spina This change ports the Review model to TypeScript and spina. Testing Done: Ran unit tests.	366dd8c99365bb495a15c577fcc00b3d39565757

Issues

Description	From	Last Updated
Missing docs.	chipx86	Aug. 2, 2023, 1:46 p.m.
Since these prototypeAttrs are already set on BaseResource, I thought we didn't have to include this here because they get …	maubin	Aug. 2, 2023, 1:13 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/reviewModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Missing docs.

david Aug. 2, 2023, 9:19 a.m.

So I'm a little conflicted here. I feel like it's useful to have this interface for type checking of parse methods, but it's not part of the API surface of the model. The items here also are completely duplicated by our webapi documentation and overlap almost 100% with the docs for the model attributes.

chipx86 Aug. 2, 2023, 1:08 p.m.

Yeah, I get those arguments for sure. I guess given that these are API data (which I wasn't really thinking about when I wrote this), we can make an exception.

reviewboard/static/rb/js/common/resources/models/reviewModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Since these prototypeAttrs are already set on BaseResource, I thought we didn't have to include this here because they get inherited?

chipx86 Aug. 2, 2023, 1:08 p.m.

They're supposed to, but David's noticed a bug in Spina preventing this from working. I haven't worked it out yet.

maubin Aug. 2, 2023, 1:13 p.m.
```
Oh got it.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (15e9e30)