Add the ability to use next and previous buttons for SlideshowView.

Review Request #13165 — Created July 31, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

The SlideshowView implementation ported over from rb-website assumed
that the nav was basically a table of contents, with a nav item for each
slide. This change adds functionality to use next/previous buttons
instead (you cannot currently use both).

Used in conjunction with a change that adds a slideshow to the review
dialog.

Summary ID
Add the ability to use next and previous buttons for SlideshowView.
The SlideshowView implementation ported over from rb-website assumed that the nav was basically a table of contents, with a nav item for each slide. This change adds functionality to use next/previous buttons instead (you cannot currently use both). Testing Done: Used in conjunction with a change that adds a slideshow to the review dialog.
445473177534b3b5f047d485a9923ffebfd6fc04
Description From Last Updated

Can you have the "Alternatively, ..." align within the structure, in its own paragraph? This should all be under the …

chipx86chipx86

Missing types.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/static/rb/css/ui/slideshow.less (Diff revision 1)
     
     
     
     
     
     

    Can you have the "Alternatively, ..." align within the structure, in its own paragraph? This should all be under the "Structure" header to format right (... ok it currently doesn't render anywhere, but I have some prototype code sitting around for this).

  3. Missing types.

  4. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (c2cf6c6)
Loading...