Summary

Add the ability to use next and previous buttons for SlideshowView.

Review Request #13165 — Created July 31, 2023 and submitted Aug. 3, 2023, 7:18 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The SlideshowView implementation ported over from rb-website assumed
that the nav was basically a table of contents, with a nav item for each
slide. This change adds functionality to use next/previous buttons
instead (you cannot currently use both).

Testing Done

Used in conjunction with a change that adds a slideshow to the review
dialog.

Commits

Summary	ID
Add the ability to use next and previous buttons for SlideshowView. The SlideshowView implementation ported over from rb-website assumed that the nav was basically a table of contents, with a nav item for each slide. This change adds functionality to use next/previous buttons instead (you cannot currently use both). Testing Done: Used in conjunction with a change that adds a slideshow to the review dialog.	445473177534b3b5f047d485a9923ffebfd6fc04

Summary

Add the ability to use next and previous buttons for SlideshowView.

The SlideshowView implementation ported over from rb-website assumed that the nav was basically a table of contents, with a nav item for each slide. This change adds functionality to use next/previous buttons instead (you cannot currently use both). Testing Done: Used in conjunction with a change that adds a slideshow to the review dialog.

445473177534b3b5f047d485a9923ffebfd6fc04

Issues

Description	From	Last Updated
Can you have the "Alternatively, ..." align within the structure, in its own paragraph? This should all be under the …	chipx86	Aug. 2, 2023, 4:50 p.m.
Missing types.	chipx86	Aug. 2, 2023, 4:51 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/ui/slideshow.less (Diff revision 1)

The issue has been resolved. Show all issues

Can you have the "Alternatively, ..." align within the structure, in its own paragraph? This should all be under the "Structure" header to format right (... ok it currently doesn't render anywhere, but I have some prototype code sitting around for this).

reviewboard/static/rb/js/ui/views/slideshowView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing types.
```

Commits:

	Summary	ID
	Add the ability to use next and previous buttons for SlideshowView. The SlideshowView implementation ported over from rb-website assumed that the nav was basically a table of contents, with a nav item for each slide. This change adds functionality to use next/previous buttons instead (you cannot currently use both). Testing Done: Used in conjunction with a change that adds a slideshow to the review dialog.	f1e9f279bc23da5f9caf1e1b30dc2143ef00952b
	Add the ability to use next and previous buttons for SlideshowView. The SlideshowView implementation ported over from rb-website assumed that the nav was basically a table of contents, with a nav item for each slide. This change adds functionality to use next/previous buttons instead (you cannot currently use both). Testing Done: Used in conjunction with a change that adds a slideshow to the review dialog.	445473177534b3b5f047d485a9923ffebfd6fc04

Diff:

Revision 2 (+130 -20)

Show changes

	reviewboard/static/rb/css/ui/slideshow.less
	reviewboard/static/rb/js/ui/views/slideshowView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (c2cf6c6)