Summary

Port SlideshowView over from rb-website.

Review Request #13164 — Created July 31, 2023 and submitted Aug. 3, 2023, 12:18 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The rb-website codebase has a very nice slideshow/carousel

implementation. This change brings it over to Review Board, porting to

TypeScript and changing the class names to match.

Testing Done

Used in conjunction with a future change to the review dialog.

Commits

Summary	ID
Port SlideshowView over from rb-website. The rb-website codebase has a very nice slideshow/carousel implementation. This change brings it over to Review Board, porting to TypeScript and changing the class names to match. Testing Done: Used in conjunction with a future change to the review dialog.	449fdfadf742edc251957fc7577529211b7d44ac

Issues

Description	From	Last Updated
Missing type.	chipx86	Aug. 2, 2023, 9:07 a.m.
Missing type.	chipx86	Aug. 2, 2023, 9:07 a.m.
This should be in multi-line form (multiple types).	chipx86	Aug. 2, 2023, 9:07 a.m.
Typo: "slidshow" -> "slideshow"	maubin	Aug. 2, 2023, 9:50 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/ui/views/slideshowView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing type.
```
reviewboard/static/rb/js/ui/views/slideshowView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing type.
```
reviewboard/static/rb/js/ui/views/slideshowView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be in multi-line form (multiple types).
```

Commits:

	Summary	ID
	Port SlideshowView over from rb-website. The rb-website codebase has a very nice slideshow/carousel implementation. This change brings it over to Review Board, porting to TypeScript and changing the class names to match. Testing Done: Used in conjunction with a future change to the review dialog.	8d28b92529beefb17b12a0ca3e5cb02adb89adb0
	Port SlideshowView over from rb-website. The rb-website codebase has a very nice slideshow/carousel implementation. This change brings it over to Review Board, porting to TypeScript and changing the class names to match. Testing Done: Used in conjunction with a future change to the review dialog.	449fdfadf742edc251957fc7577529211b7d44ac

Diff:

Revision 2 (+1408)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/ui/slideshow.less
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/ui/views/slideshowView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/css/ui/slideshow.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "slidshow" -> "slideshow"
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (42ccbd8)