Summary

Allow action menus to specify order and add separators.

Review Request #13162 — Created July 27, 2023 and submitted July 28, 2023, 1:50 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Menu-type actions were restricted to rendering in the order that actions
were registered, but this is highly annoying when pulling in actions
from multiple different places, including extensions.

This change adds the ability for a menu action to define the order of
the children, and adds a new separator implementation (defined with the
custom "--" name in the order). Any actions which are in the menu but
not explicitly specified in the child order will be added at the end of
the menu.

Testing Done

Created a menu action and specified the child order. Saw that I was able
to reorder the menu items as expected. Verified that separators worked
and looked good.

Commits

Summary	ID
Allow action menus to specify order and add separators. Menu-type actions were restricted to rendering in the order that actions were registered, but this is highly annoying when pulling in actions from multiple different places, including extensions. This change adds the ability for a menu action to define the order of the children, and adds a new separator implementation (defined with the custom "--" name in the order). Any actions which are in the menu but not explicitly specified in the child order will be added at the end of the menu. Testing Done: Created a menu action and specified the child order. Saw that I was able to reorder the menu items as expected. Verified that separators worked and looked good.	eab4d2569ecb863d33cb7a32df9e746ae62a3e1b

Summary

Allow action menus to specify order and add separators.

Menu-type actions were restricted to rendering in the order that actions were registered, but this is highly annoying when pulling in actions from multiple different places, including extensions. This change adds the ability for a menu action to define the order of the children, and adds a new separator implementation (defined with the custom "--" name in the order). Any actions which are in the menu but not explicitly specified in the child order will be added at the end of the menu. Testing Done: Created a menu action and specified the child order. Saw that I was able to reorder the menu items as expected. Verified that separators worked and looked good.

eab4d2569ecb863d33cb7a32df9e746ae62a3e1b

flake8 passed.

JSHint passed.

Description:

		Menu-type actions were restricted to rendering in the order that actions
		were registered, but this is highly annoying when pulling in actions
		from multiple different places, including extensions.

		This change adds the ability for a menu action to define the order of
		the children, and adds a new separator implementation (defined with the
		custom "--" name in the order). Any actions which are in the menu but
		not explicitly specified in the child order will be added at the end of
		the menu.
-
-		Testing Done:
-		Created a menu action and specified the child order. Saw that I was able
-		to reorder the menu items as expected. Verified that separators worked
-		and looked good.

Testing Done:

	+	Created a menu action and specified the child order. Saw that I was able
	+	to reorder the menu items as expected. Verified that separators worked
	+	and looked good.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (b48786e)