This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (83310eb)

Summary

Port the ReviewDialogView to TypeScript/spina.

Review Request #13157 — Created July 21, 2023 and submitted 1 year, 9 months ago — Latest diff uploaded 1 year, 9 months ago

Information

Owner

david*

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
the ResourceCollectionOptions needed to mark the fields as optional.

Testing Done


Ran js-tests.
Used the review dialog with different comment types.

Changes between revision 2 and 3

orig

Commits

	Summary	ID	Author
	Port the ReviewDialogView to TypeScript/spina. This change ports the ReviewDialogView over to TypeScript. This is pretty mechanical throughout. The only wart that this uncovered is that the `ResourceCollectionOptions` needed to mark the fields as optional. Testing Done: - Ran js-tests. - Used the review dialog with different comment types.	34578c6ca5eccaee4def1edfa8b51b5d1ac3e1b3	David Trowbridge
	Port the ReviewDialogView to TypeScript/spina. This change ports the ReviewDialogView over to TypeScript. This is pretty mechanical throughout. The only wart that this uncovered is that the `ResourceCollectionOptions` needed to mark the fields as optional. Testing Done: - Ran js-tests. - Used the review dialog with different comment types.	d58b4d8bbe1835f6117a63f124b15943b4762a67	David Trowbridge

Files

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/views/reviewDialogView.ts

reviewboard/staticbundles.py

reviewboard/static/rb/js/reviews/views/reviewDialogView.ts