flake8
passed.
JSHint
passed.
Port the ReviewDialogView to TypeScript/spina.
Review Request #13157 — Created July 21, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
theResourceCollectionOptionsneeded to mark the fields as optional.
- Ran js-tests.
- Used the review dialog with different comment types.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
We can combine this. The parent returns this. |
 chipx86
|
|
|
You should be able to remove the interpolate now and just reference the variables using template literal variables. The tag … |
chipx86
|
|
|
Should be spread across lines (multiple types). |
chipx86
|
|
|
This is missing docs. |
chipx86
|
|
|
These are missing docs. |
chipx86
|
|
|
These can be combined into one statement. |
chipx86
|
|
|
If you pull the summary out into a variable, you can reference it in the _ and avoid writing an … |
chipx86
|
|
|
suite is part of our jasmine-suites, not jasmine itself. |
chipx86
|
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) We can combine this. The parent returns
this. -
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) You should be able to remove the
interpolatenow and just reference the variables using template literal variables. The tag will add theinterpolateas needed. -
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) Should be spread across lines (multiple types).
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) These are missing docs.
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) These can be combined into one statement.
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) If you pull the summary out into a variable, you can reference it in the
_and avoid writing aninterpolate. -
reviewboard/static/rb/js/reviews/views/tests/reviewDialogViewTests.ts (Diff revision 1) suiteis part of our jasmine-suites, not jasmine itself.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1378 -962) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revisions 1 - 2) This is missing docs.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1390 -966) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
