Port the ReviewDialogView to TypeScript/spina.

Review Request #13157 — Created July 21, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
the ResourceCollectionOptions needed to mark the fields as optional.

  • Ran js-tests.
  • Used the review dialog with different comment types.
Summary ID
Port the ReviewDialogView to TypeScript/spina.
This change ports the ReviewDialogView over to TypeScript. This is pretty mechanical throughout. The only wart that this uncovered is that the `ResourceCollectionOptions` needed to mark the fields as optional. Testing Done: - Ran js-tests. - Used the review dialog with different comment types.
d58b4d8bbe1835f6117a63f124b15943b4762a67
Description From Last Updated

We can combine this. The parent returns this.

chipx86chipx86

You should be able to remove the interpolate now and just reference the variables using template literal variables. The tag …

chipx86chipx86

Should be spread across lines (multiple types).

chipx86chipx86

This is missing docs.

chipx86chipx86

These are missing docs.

chipx86chipx86

These can be combined into one statement.

chipx86chipx86

If you pull the summary out into a variable, you can reference it in the _ and avoid writing an …

chipx86chipx86

suite is part of our jasmine-suites, not jasmine itself.

chipx86chipx86
chipx86
  1. 
      
  2. We can combine this. The parent returns this.

  3. reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1)
     
     
     
     
     
     
     
     
     
     

    You should be able to remove the interpolate now and just reference the variables using template literal variables. The tag will add the interpolate as needed.

  4. Should be spread across lines (multiple types).

  5. These are missing docs.

  6. These can be combined into one statement.

  7. If you pull the summary out into a variable, you can reference it in the _ and avoid writing an interpolate.

  8. suite is part of our jasmine-suites, not jasmine itself.

    1. I'll just remove that for now until I figure out the right solution.

  9. 
      
david
chipx86
  1. 
      
  2. This is missing docs.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (83310eb)
Loading...