Port the ReviewDialogView to TypeScript/spina.
Review Request #13157 — Created July 21, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
theResourceCollectionOptions
needed to mark the fields as optional.
- Ran js-tests.
- Used the review dialog with different comment types.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
We can combine this. The parent returns this. |
|
|
You should be able to remove the interpolate now and just reference the variables using template literal variables. The tag … |
|
|
Should be spread across lines (multiple types). |
|
|
This is missing docs. |
|
|
These are missing docs. |
|
|
These can be combined into one statement. |
|
|
If you pull the summary out into a variable, you can reference it in the _ and avoid writing an … |
|
|
suite is part of our jasmine-suites, not jasmine itself. |
|
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) We can combine this. The parent returns
this
. -
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) You should be able to remove the
interpolate
now and just reference the variables using template literal variables. The tag will add theinterpolate
as needed. -
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) Should be spread across lines (multiple types).
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) These are missing docs.
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) These can be combined into one statement.
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1) If you pull the summary out into a variable, you can reference it in the
_
and avoid writing aninterpolate
. -
reviewboard/static/rb/js/reviews/views/tests/reviewDialogViewTests.ts (Diff revision 1) suite
is part of our jasmine-suites, not jasmine itself.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1378 -962) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revisions 1 - 2) This is missing docs.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1390 -966) |