Port the ReviewDialogView to TypeScript/spina.

 






 

 


  Review Request #13157
  —
  Created July 21, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change ports the ReviewDialogView over to TypeScript. This is

pretty mechanical throughout. The only wart that this uncovered is that

the ResourceCollectionOptions needed to mark the fields as optional.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used the review dialog with different comment types.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Port the ReviewDialogView to TypeScript/spina.
     
This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
the `ResourceCollectionOptions` needed to mark the fields as optional.

Testing Done:
- Ran js-tests.
- Used the review dialog with different comment types.

    

   
  		
  34578c6ca5eccaee4def1edfa8b51b5d1ac3e1b3
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/reviewDialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewDialogViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...