flake8
passed.
JSHint
passed.
Port the ReviewDialogView to TypeScript/spina.
Review Request #13157 — Created July 21, 2023 and submitted
This change ports the ReviewDialogView over to TypeScript. This is
pretty mechanical throughout. The only wart that this uncovered is that
theResourceCollectionOptionsneeded to mark the fields as optional.
- Ran js-tests.
- Used the review dialog with different comment types.
| Summary | ID |
|---|---|
| d58b4d8bbe1835f6117a63f124b15943b4762a67 |
| Description | From | Last Updated |
|---|---|---|
|
We can combine this. The parent returns this. |
 chipx86
|
|
|
You should be able to remove the interpolate now and just reference the variables using template literal variables. The tag … |
chipx86
|
|
|
Should be spread across lines (multiple types). |
chipx86
|
|
|
This is missing docs. |
chipx86
|
|
|
These are missing docs. |
chipx86
|
|
|
These can be combined into one statement. |
chipx86
|
|
|
If you pull the summary out into a variable, you can reference it in the _ and avoid writing an … |
chipx86
|
|
|
suite is part of our jasmine-suites, not jasmine itself. |
chipx86
|
- Commits:
-
Summary ID b3f70387a621342be7b27d1fa83bd885e5b735e0 34578c6ca5eccaee4def1edfa8b51b5d1ac3e1b3 - Diff:
-
Revision 2 (+1378 -962)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID 34578c6ca5eccaee4def1edfa8b51b5d1ac3e1b3 d58b4d8bbe1835f6117a63f124b15943b4762a67 - Diff:
-
Revision 3 (+1390 -966)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
