This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-4.x (7c58a65)

Summary

Update djblets.mail for typing, enums, and deprecations.

Review Request #13154 — Created July 19, 2023 and submitted 1 year, 9 months ago — Latest diff uploaded 1 year, 10 months ago

Information

Owner

chipx86*

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

This updates EmailMessage, DMARC code, and utilities to provide Python
type hints for all arguments and results, helping ensure consistency in
usage and behavior. This actually caught a couple of issues with None
values being fed into EmailMessage at points.

Positional arguments to EmailMessage and the enable_smart_spoofing
argument are deprecated, scheduled for removal in Djblets 6.

This all prepares for some upcoming work on this module.

Testing Done

Unit tests pass in Djblets and Review Board.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig

Commits

First	Last	Summary	ID	Author
		Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	25c0acb2c2b11ae67c1e653a8217ede32b608b5a	Christian Hammond

Files

	djblets/mail/dmarc.py
	djblets/mail/message.py
	djblets/mail/testing.py
	djblets/mail/tests.py
	djblets/mail/utils.py

djblets/mail/dmarc.py

djblets/mail/message.py

djblets/mail/testing.py

djblets/mail/tests.py

djblets/mail/utils.py