Summary

Update djblets.mail for typing, enums, and deprecations.

Review Request #13154 — Created July 19, 2023 and submitted July 31, 2023, 11:35 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This updates EmailMessage, DMARC code, and utilities to provide Python
type hints for all arguments and results, helping ensure consistency in
usage and behavior. This actually caught a couple of issues with None
values being fed into EmailMessage at points.

Positional arguments to EmailMessage and the enable_smart_spoofing
argument are deprecated, scheduled for removal in Djblets 6.

This all prepares for some upcoming work on this module.

Testing Done

Unit tests pass in Djblets and Review Board.

Commits

Summary	ID
Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	7c610bb22c73d16493ebfdf7cb2b68e0b03ec60d

Summary

Update djblets.mail for typing, enums, and deprecations.

This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.

7c610bb22c73d16493ebfdf7cb2b68e0b03ec60d

Issues

Description	From	Last Updated
'typing_extensions.TypeAlias' imported but unused Column: 1 Error code: F401	reviewbot	July 19, 2023, 5:31 p.m.
'enum.Enum' imported but unused Column: 1 Error code: F401	reviewbot	July 19, 2023, 5:31 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/mail/dmarc.py (Diff revision 1)

The issue has been resolved. Show all issues

'typing_extensions.TypeAlias' imported but unused

Column: 1
Error code: F401

djblets/mail/message.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'enum.Enum' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	5224ead1f4f67457da1a77cdd75f87e831d53fb7
	Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	25c0acb2c2b11ae67c1e653a8217ede32b608b5a

Diff:

Revision 2 (+774 -296)

Show changes

	djblets/mail/dmarc.py
	djblets/mail/message.py
	djblets/mail/testing.py
	djblets/mail/tests.py
	djblets/mail/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Remove the accidental addition of the reply_to parameter.

Commits:

	Summary	ID
	Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	25c0acb2c2b11ae67c1e653a8217ede32b608b5a
	Update djblets.mail for typing, enums, and deprecations. This updates `EmailMessage`, DMARC code, and utilities to provide Python type hints for all arguments and results, helping ensure consistency in usage and behavior. This actually caught a couple of issues with `None` values being fed into `EmailMessage` at points. Positional arguments to `EmailMessage` and the `enable_smart_spoofing` argument are deprecated, scheduled for removal in Djblets 6. This all prepares for some upcoming work on this module.	7c610bb22c73d16493ebfdf7cb2b68e0b03ec60d

Diff:

Revision 3 (+772 -296)

Show changes

	djblets/mail/dmarc.py
	djblets/mail/message.py
	djblets/mail/testing.py
	djblets/mail/tests.py
	djblets/mail/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (7c58a65)