flake8
-
djblets/mail/dmarc.py (Diff revision 1) Show all issues -
djblets/mail/message.py (Diff revision 1) 'enum.Enum' imported but unused Column: 1 Error code: F401
Review Request #13154 — Created July 20, 2023 and submitted
This updates
EmailMessage
, DMARC code, and utilities to provide Python
type hints for all arguments and results, helping ensure consistency in
usage and behavior. This actually caught a couple of issues withNone
values being fed intoEmailMessage
at points.Positional arguments to
EmailMessage
and theenable_smart_spoofing
argument are deprecated, scheduled for removal in Djblets 6.This all prepares for some upcoming work on this module.
Unit tests pass in Djblets and Review Board.
djblets/mail/dmarc.py (Diff revision 1) |
---|
djblets/mail/message.py (Diff revision 1) |
---|
'enum.Enum' imported but unused Column: 1 Error code: F401
Removed unused imports.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+774 -296) |
Remove the accidental addition of the
reply_to
parameter.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+772 -296) |