Update djblets.mail for typing, enums, and deprecations.

 






 

 


  Review Request #13154
  —
  Created July 19, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This updates EmailMessage, DMARC code, and utilities to provide Python

type hints for all arguments and results, helping ensure consistency in

usage and behavior. This actually caught a couple of issues with None

values being fed into EmailMessage at points.


Positional arguments to EmailMessage and the enable_smart_spoofing

argument are deprecated, scheduled for removal in Djblets 6.


This all prepares for some upcoming work on this module.

 








  


 
 

  
Unit tests pass in Djblets and Review Board.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update djblets.mail for typing, enums, and deprecations.
     
This updates `EmailMessage`, DMARC code, and utilities to provide Python
type hints for all arguments and results, helping ensure consistency in
usage and behavior. This actually caught a couple of issues with `None`
values being fed into `EmailMessage` at points.

Positional arguments to `EmailMessage` and the `enable_smart_spoofing`
argument are deprecated, scheduled for removal in Djblets 6.

This all prepares for some upcoming work on this module.

    

   
  		
  5224ead1f4f67457da1a77cdd75f87e831d53fb7
  Christian Hammond
 


 
  
 
 
  
   
    

     Update djblets.mail for typing, enums, and deprecations.
     
This updates `EmailMessage`, DMARC code, and utilities to provide Python
type hints for all arguments and results, helping ensure consistency in
usage and behavior. This actually caught a couple of issues with `None`
values being fed into `EmailMessage` at points.

Positional arguments to `EmailMessage` and the `enable_smart_spoofing`
argument are deprecated, scheduled for removal in Djblets 6.

This all prepares for some upcoming work on this module.

    

   
  		
  25c0acb2c2b11ae67c1e653a8217ede32b608b5a
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/mail/dmarc.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/mail/message.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...