[WIP] Add an is_draft property to file attachments.

Review Request #13138 — Created July 13, 2023 and discarded — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

This adds an is_draft property to file attachments, to easily check
when a file attachment is a draft or if it's published. This also
updates areas in the code where we check if a file attachment is a
draft. And unit tests for the file attachment resources have been
updated to check all of the fields of the file attachment.

  • Ran unit tests.
  • Used the property in upcoming changes.
  • Tested uploading user file attachments to comments, saw
    nothing out of the ordinary.

Changes between revision 4 and 5

orig
1
2
3
4
5
6
7
8

Commits

Summary ID Author
Add an is_draft property to file attachments.
73b3d50977a7066d84c01bb25f6b2d23f8ab809d Michelle Aubin
Add an is_draft property to file attachments.
abbe4bf1fc1aa6e3e9f64e56ab0aa45e022feb17 Michelle Aubin
reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js
Loading...