flake8
passed.
JSHint
passed.
Perform extra cleanup when review request drafts get discarded.
Review Request #13135 — Created July 13, 2023 and submitted
This adds a handler for performing extra cleanup when review request drafts
get deleted. Right now the only thing that we do in the handler is delete all
draft file attachments that are being discarded alongside the draft. That
fixes a bug where discarding a review request draft that contained an
update to a file attachment would erase the entire file attachment from the
review request, rather than reverting the file attachment to its previously
published version. It also makes sense to not keep the draft file attachment
around, since it will never be published/accessed again after being discarded.
- Ran unit tests
- Made sure that the bug was fixed.
| Summary |
|---|
| Description | From | Last Updated |
|---|---|---|
|
I left a similar comment on /r/13142/, but I think we should do the deletion in the model, to keep … |
 chipx86
|
|
|
These should just be parens for a tuple. A set has a bit more overhead that won't result in anything … |
chipx86
|
|
|
continuation line over-indented for hanging indent Column: 14 Error code: E126 |
 reviewbot
|
Change Summary:
- Moved to RB6.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Branch: |
|
||||||
Diff: |
Revision 2 (+158) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/signal_handlers.py (Diff revision 2) I left a similar comment on /r/13142/, but I think we should do the deletion in the model, to keep the logic in one place. Signals are more useful if we're dealing with code we don't control or performing operations unrelated to the purpose of that model. In this case,
ReviewRequestDraftmanages its file attachments, and as such should also manage its deletion.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+400) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/signal_handlers.py (Diff revision 3) continuation line over-indented for hanging indent Column: 14 Error code: E126
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+400) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/signal_handlers.py (Diff revisions 2 - 4) These should just be parens for a tuple. A set has a bit more overhead that won't result in anything faster than just scanning a tuple in this case.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+400) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.