[WIP] Add an is_draft property to file attachments.

Review Request #13138 — Created July 13, 2023 and discarded — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

This adds an is_draft property to file attachments, to easily check
when a file attachment is a draft or if it's published. This also
updates areas in the code where we check if a file attachment is a
draft. And unit tests for the file attachment resources have been
updated to check all of the fields of the file attachment.

  • Ran unit tests.
  • Used the property in upcoming changes.
  • Tested uploading user file attachments to comments, saw
    nothing out of the ordinary.
reviewboard/attachments/models.py
reviewboard/attachments/tests.py
reviewboard/reviews/builtin_fields.py
reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js
reviewboard/webapi/resources/base_file_attachment.py
reviewboard/webapi/resources/base_review_request_file_attachment.py
reviewboard/webapi/tests/test_file_attachment.py
reviewboard/webapi/tests/test_file_attachment_draft.py
Loading...