Fish Trophy

david got a fish trophy!

Fish Trophy

Catch errors when uninitializing ActionHook.

Review Request #13131 — Created June 30, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

I recently hit a case where an extension that adds a bunch of actions
was hitting errors during devserver initialization and reloads. The
issue seems to be that it was never fully initialized, then the
devserver reloaded, and hitting an error during the extension shutdown
was leaving old action registrations around, which would then fail due
to duplicates. This seems like it's probably a devserver-specific
problem, but it's annoying. This change catches any ItemLookupErrors
that get triggered during ActionHook shutdown.

Was able to use my extension.

Summary ID
Catch errors when uninitializing ActionHook.
I recently hit a case where an extension that adds a bunch of actions was hitting errors during devserver initialization and reloads. The issue seems to be that it was never fully initialized, then the devserver reloaded, and hitting an error during the extension shutdown was leaving old action registrations around, which would then fail due to duplicates. This seems like it's probably a devserver-specific problem, but it's annoying. This change catches any ItemLookupErrors that get triggered during ActionHook shutdown. Testing Done: Was able to use my extension.
a53fbc8b9ae948aae67a35443d964abdf1f9bdf4
maubin
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (d334a74)