Update Djblets to use Housekeeping for deprecation management.

 






 

 


  Review Request #13124
  —
  Created June 23, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This adds a dependency on housekeeping, our new deprecation management

library, and switches all of our base classes over to it.


The original base class and deprecation utility functions are still

there, but wrap the versions in housekeeping. They themselves are marked

as deprecated and will be removed in Djblets 6.


The BaseRemovedInProductVersionWarning is deprecated, but remains for

now. We can't mark it as moved or deprecated using housekeeping, given

circular references (which Housekeeping 1.1 was supposed to fix, but

ultimately couldn't).

 








  


 
 

  
Unit tests pass in Djblets and Review Board.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update Djblets to use Housekeeping for deprecation management.
     
This adds a dependency on housekeeping, our new deprecation management
library, and switches all of our base classes over to it.

The original base class and deprecation utility functions are still
there, but wrap the versions in housekeeping. They themselves are marked
as deprecated and will be removed in Djblets 6.

Housekeeping 1.1 is needed in order to allow us to retain
`BaseRemovedInProductVersionWarning` as a base class (until removed in
Djblets 6) while also marking it deprecated and avoiding a warning in
the `PendingRemovalInDjbletsWarning` subclass.

    

   
  		
  4c15bdfcb830db49d725b9a0784dcf61d1a4cad7
  Christian Hammond
 


 
  
 
 
  
   
    

     Update Djblets to use Housekeeping for deprecation management.
     
This adds a dependency on housekeeping, our new deprecation management
library, and switches all of our base classes over to it.

The original base class and deprecation utility functions are still
there, but wrap the versions in housekeeping. They themselves are marked
as deprecated and will be removed in Djblets 6.

The `BaseRemovedInProductVersionWarning` is deprecated, but remains for
now. We can't mark it as moved or deprecated using housekeeping, given
circular references (which Housekeeping 1.1 was supposed to fix, but
ultimately couldn't).

    

   
  		
  a188eab022966ae54312f15ae5a242d830f0a4f8
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/deprecation.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...