Summary

Update Djblets to use Housekeeping for deprecation management.

Review Request #13124 — Created June 23, 2023 and submitted July 6, 2023, 1:27 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This adds a dependency on housekeeping, our new deprecation management

library, and switches all of our base classes over to it.
The original base class and deprecation utility functions are still

there, but wrap the versions in housekeeping. They themselves are marked

as deprecated and will be removed in Djblets 6.
The BaseRemovedInProductVersionWarning is deprecated, but remains for

now. We can't mark it as moved or deprecated using housekeeping, given

circular references (which Housekeeping 1.1 was supposed to fix, but

ultimately couldn't).

Testing Done

Unit tests pass in Djblets and Review Board.

Commits

Summary	ID
Update Djblets to use Housekeeping for deprecation management. This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. The `BaseRemovedInProductVersionWarning` is deprecated, but remains for now. We can't mark it as moved or deprecated using housekeeping, given circular references (which Housekeeping 1.1 was supposed to fix, but ultimately couldn't).	a188eab022966ae54312f15ae5a242d830f0a4f8

Summary

Update Djblets to use Housekeeping for deprecation management.

This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. The `BaseRemovedInProductVersionWarning` is deprecated, but remains for now. We can't mark it as moved or deprecated using housekeeping, given circular references (which Housekeeping 1.1 was supposed to fix, but ultimately couldn't).

a188eab022966ae54312f15ae5a242d830f0a4f8

Issues

Description	From	Last Updated
'housekeeping.func_deprecated' imported but unused Column: 1 Error code: F401	reviewbot	June 23, 2023, 5:08 p.m.
'housekeeping.BasePendingRemovalWarning' imported but unused Column: 1 Error code: F401	reviewbot	June 23, 2023, 5:08 p.m.
'housekeeping.ClassMovedMixin' imported but unused Column: 1 Error code: F401	reviewbot	July 3, 2023, 7:08 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/deprecation.py (Diff revision 1)

The issue has been resolved. Show all issues

'housekeeping.func_deprecated' imported but unused

Column: 1
Error code: F401

djblets/deprecation.py (Diff revision 1)

The issue has been resolved. Show all issues

'housekeeping.BasePendingRemovalWarning' imported but unused

Column: 1
Error code: F401

Change Summary:


Removed an unused import.
Fixed the base classes for pending vs. removed-in warning classes.

Commits:

	Summary	ID
	Update Djblets to use Housekeeping for deprecation management. This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. Housekeeping 1.1 is needed in order to allow us to retain `BaseRemovedInProductVersionWarning` as a base class (until removed in Djblets 6) while also marking it deprecated and avoiding a warning in the `PendingRemovalInDjbletsWarning` subclass.	6c9ae5b65823ef05df772a6719e80645634e9b7e
	Update Djblets to use Housekeeping for deprecation management. This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. Housekeeping 1.1 is needed in order to allow us to retain `BaseRemovedInProductVersionWarning` as a base class (until removed in Djblets 6) while also marking it deprecated and avoiding a warning in the `PendingRemovalInDjbletsWarning` subclass.	4c15bdfcb830db49d725b9a0784dcf61d1a4cad7

Diff:

Revision 2 (+180 -526)

Show changes

	djblets/dependencies.py
	djblets/deprecation.py
	djblets/pipeline/settings.py
	djblets/util/properties.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (0a9315d)

Status: Re-opened

Change Summary:

Removed the deprecation warning for BaseRemovedInProductVersionWarning.

Description:

		This adds a dependency on housekeeping, our new deprecation management
		library, and switches all of our base classes over to it.

		The original base class and deprecation utility functions are still
		there, but wrap the versions in housekeeping. They themselves are marked
		as deprecated and will be removed in Djblets 6.

~		Housekeeping 1.1 is needed in order to allow us to retain
~		`BaseRemovedInProductVersionWarning` as a base class (until removed in
~		Djblets 6) while also marking it deprecated and avoiding a warning in
~		the `PendingRemovalInDjbletsWarning` subclass.
	~	The `BaseRemovedInProductVersionWarning` is deprecated, but remains for
	~	now. We can't mark it as moved or deprecated using housekeeping, given
	~	circular references (which Housekeeping 1.1 was supposed to fix, but
	~	ultimately couldn't).

Commits:

	Summary	ID
	Update Djblets to use Housekeeping for deprecation management. This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. Housekeeping 1.1 is needed in order to allow us to retain `BaseRemovedInProductVersionWarning` as a base class (until removed in Djblets 6) while also marking it deprecated and avoiding a warning in the `PendingRemovalInDjbletsWarning` subclass.	4c15bdfcb830db49d725b9a0784dcf61d1a4cad7
	Update Djblets to use Housekeeping for deprecation management. This adds a dependency on housekeeping, our new deprecation management library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. The `BaseRemovedInProductVersionWarning` is deprecated, but remains for now. We can't mark it as moved or deprecated using housekeeping, given circular references (which Housekeeping 1.1 was supposed to fix, but ultimately couldn't).	a188eab022966ae54312f15ae5a242d830f0a4f8

Diff:

Revision 3 (+172 -526)

Show changes

	djblets/dependencies.py
	djblets/deprecation.py
	djblets/pipeline/settings.py
	djblets/util/properties.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/deprecation.py (Diff revision 3)

The issue has been resolved. Show all issues

'housekeeping.ClassMovedMixin' imported but unused

Column: 1
Error code: F401

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (415a1fd)