Update Djblets to use Housekeeping for deprecation management.
Review Request #13124 — Created June 23, 2023 and submitted
This adds a dependency on housekeeping, our new deprecation management
library, and switches all of our base classes over to it.The original base class and deprecation utility functions are still
there, but wrap the versions in housekeeping. They themselves are marked
as deprecated and will be removed in Djblets 6.The
BaseRemovedInProductVersionWarning
is deprecated, but remains for
now. We can't mark it as moved or deprecated using housekeeping, given
circular references (which Housekeeping 1.1 was supposed to fix, but
ultimately couldn't).
Unit tests pass in Djblets and Review Board.
Summary | ID |
---|---|
a188eab022966ae54312f15ae5a242d830f0a4f8 |
Description | From | Last Updated |
---|---|---|
'housekeeping.func_deprecated' imported but unused Column: 1 Error code: F401 |
reviewbot | |
'housekeeping.BasePendingRemovalWarning' imported but unused Column: 1 Error code: F401 |
reviewbot | |
'housekeeping.ClassMovedMixin' imported but unused Column: 1 Error code: F401 |
reviewbot |
- Change Summary:
-
- Removed an unused import.
- Fixed the base classes for pending vs. removed-in warning classes.
- Commits:
-
Summary ID 6c9ae5b65823ef05df772a6719e80645634e9b7e 4c15bdfcb830db49d725b9a0784dcf61d1a4cad7
Checks run (2 succeeded)
- Change Summary:
-
Removed the deprecation warning for
BaseRemovedInProductVersionWarning
. - Description:
-
This adds a dependency on housekeeping, our new deprecation management
library, and switches all of our base classes over to it. The original base class and deprecation utility functions are still
there, but wrap the versions in housekeeping. They themselves are marked as deprecated and will be removed in Djblets 6. ~ Housekeeping 1.1 is needed in order to allow us to retain
~ BaseRemovedInProductVersionWarning
as a base class (until removed in~ Djblets 6) while also marking it deprecated and avoiding a warning in ~ the PendingRemovalInDjbletsWarning
subclass.~ The
BaseRemovedInProductVersionWarning
is deprecated, but remains for~ now. We can't mark it as moved or deprecated using housekeeping, given ~ circular references (which Housekeeping 1.1 was supposed to fix, but ~ ultimately couldn't). - Commits:
-
Summary ID 4c15bdfcb830db49d725b9a0784dcf61d1a4cad7 a188eab022966ae54312f15ae5a242d830f0a4f8