Summary

Add new filtering options for lists of review groups in the API.

Review Request #13121 — Created June 22, 2023 and submitted July 3, 2023, 7:15 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The review groups resource now accepts two new arguments:

?show-invisible=1, which will include any review groups not marked
as visible.
?invite-only=<bool>, which will filter the review groups based on
the invite_only flag.

This doesn't allow for overriding any accessibility checks. Results will
still only include those the user has access to.

Testing Done

Unit tests pass.

Made use of this with some upcoming changes for repository configuration.

Commits

Summary	ID
Add new filtering options for lists of review groups in the API. The review groups resource now accepts two new arguments: 1. `?show-invisible=1`, which will include any review groups not marked as visible. 2. `?invite-only=<bool>`, which will filter the review groups based on the `invite_only` flag. This doesn't allow for overriding any accessibility checks. Results will still only include those the user has access to.	ae66dd2f14243bc96aa558cf225371f3310c9554

Summary

Add new filtering options for lists of review groups in the API.

The review groups resource now accepts two new arguments: 1. `?show-invisible=1`, which will include any review groups not marked as visible. 2. `?invite-only=<bool>`, which will filter the review groups based on the `invite_only` flag. This doesn't allow for overriding any accessibility checks. Results will still only include those the user has access to.

ae66dd2f14243bc96aa558cf225371f3310c9554

Issues

Description	From	Last Updated
'django.contrib.auth.models.User' imported but unused Column: 1 Error code: F401	reviewbot	June 22, 2023, 5:15 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_group.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.contrib.auth.models.User' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add new filtering options for lists of review groups in the API. The review groups resource now accepts two new arguments: 1. `?show-invisible=1`, which will include any review groups not marked as visible. 2. `?invite-only=<bool>`, which will filter the review groups based on the `invite_only` flag. This doesn't allow for overriding any accessibility checks. Results will still only include those the user has access to.	d1cf4f06e1108a4c6a75e07e911f12a04594fdb4
	Add new filtering options for lists of review groups in the API. The review groups resource now accepts two new arguments: 1. `?show-invisible=1`, which will include any review groups not marked as visible. 2. `?invite-only=<bool>`, which will filter the review groups based on the `invite_only` flag. This doesn't allow for overriding any accessibility checks. Results will still only include those the user has access to.	ae66dd2f14243bc96aa558cf225371f3310c9554

Diff:

Revision 2 (+880 -20)

Show changes

	reviewboard/webapi/resources/review_group.py
	reviewboard/webapi/tests/test_review_group.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (a000782)