Summary

Fix a bug with the revision selector for file attachments.

Review Request #13119 — Created June 21, 2023 and submitted June 27, 2023, 9:25 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There was a bug with the revision selector for file attachments, where the
grey bar of the selector range would disappear when interdiffs were selected.
The problem came from improperly setting the list that stored our diff values.

Testing Done

Played around with the selector, diffing between the original and revisions,
with interdiffs and saw that the grey bar always appeared correctly.

Commits

Summary	ID
Fix a bug with the revision selector for file attachments.	b73dcba524a778dd2456aeb3662691662061b910

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Put this on 5.0.x instead of 6.0.

Commits:

	Summary	ID
	Fix a bug with the revision selector for file attachments.	1091079df44bcbed87cf685acffa07ffa74b7649
	Fix a bug with the revision selector for file attachments.	b73dcba524a778dd2456aeb3662691662061b910

Branch:

-	release-6.x
+	release-5.0.x

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/static/rb/js/views/fileAttachmentRevisionSelectorView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (4e22c8b)