Port TextEditorView and DnDUploader to spina.
Review Request #13115 — Created June 19, 2023 and submitted — Latest diff uploaded
In preparation for integrating the rich text toolbar, this change ports
ourTextEditorViewandDnDUploaderto TypeScript via spina.This also fixes one issue I discovered where if the only thing you've
done with a text editor is upload an image, it won't think the editor is
dirty and so saving discards the contents.
- Ran js-tests.
- Used drag and drop to upload files into a text editor.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| rollup.config.js |
|---|
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/js/reviews/views/commentDialogView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewablePageView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts |
|---|
| reviewboard/static/rb/js/ui/index.ts |
|---|
| reviewboard/static/rb/js/views/dndUploaderView.es6.js |
|---|
| reviewboard/static/rb/js/ui/views/inlineEditorView.ts |
|---|
| reviewboard/static/rb/js/ui/views/textEditorView.es6.js |
|---|
| reviewboard/static/rb/js/ui/views/tests/index.ts |
|---|
| reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.es6.js |
|---|