Port TextEditorView and DnDUploader to spina.
Review Request #13115 — Created June 19, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
In preparation for integrating the rich text toolbar, this change ports
ourTextEditorView
andDnDUploader
to TypeScript via spina.This also fixes one issue I discovered where if the only thing you've
done with a text editor is upload an image, it won't think the editor is
dirty and so saving discards the contents.
- Ran js-tests.
- Used drag and drop to upload files into a text editor.
Change Summary:
Forgot to squash my changes.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+988 -664) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2) Sorting imports is weird, but I think we're doing by module name?
Same elsewhere.
-
-
reviewboard/static/rb/js/ui/views/textEditorView.ts (Diff revision 2) These should be in alphabetical order.
-
reviewboard/static/rb/js/ui/views/textEditorView.ts (Diff revision 2) Should we type this
TextEditorViewOptions
? -
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1016 -664) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.