Port TextEditorView and DnDUploader to spina.

 






 

 


  Review Request #13115
  —
  Created June 19, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In preparation for integrating the rich text toolbar, this change ports

our TextEditorView and DnDUploader to TypeScript via spina.


This also fixes one issue I discovered where if the only thing you've

done with a text editor is upload an image, it won't think the editor is

dirty and so saving discards the contents.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used drag and drop to upload files into a text editor.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Port TextEditorView and DnDUploader to spina.
     
In preparation for integrating the rich text toolbar, this change ports
our `TextEditorView` and `DnDUploader` to TypeScript via spina.

This also fixes one issue I discovered where if the only thing you've
done with a text editor is upload an image, it won't think the editor is
dirty and so saving discards the contents.

Testing Done:
- Ran js-tests.
- Used drag and drop to upload files into a text editor.

    

   
  		
  d142f44a074ea10d6b60db202ed4a36275fcddbe
  David Trowbridge
 


 
  
 
 
  
   
    

     Port TextEditorView and DnDUploader to spina.
     
In preparation for integrating the rich text toolbar, this change ports
our `TextEditorView` and `DnDUploader` to TypeScript via spina.

This also fixes one issue I discovered where if the only thing you've
done with a text editor is upload an image, it won't think the editor is
dirty and so saving discards the contents.

Testing Done:
- Ran js-tests.
- Used drag and drop to upload files into a text editor.

    

   
  		
  65d1ee4ca19d64636bd69f58b6513930fc6127fb
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/dndUploaderView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/dndUploaderView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...