Summary

Update Review Bot to always use pip for developer mode.

Review Request #13085 — Created May 31, 2023 and submitted May 31, 2023, 3:36 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

setup.py develop uses legacy Python eggs and easy_install behavior,
which makes it very difficult to test modern compatibility with
packages, and causes headaches in CI.

To keep things manageable until we eventually move to pyproject.toml,
this change brings over our standard setup.py develop override that
forces usage of pip.

Testing Done

Successfully installed both in development mode.

Commits

Summary	ID
Update Review Bot to always use pip for developer mode. `setup.py develop` uses legacy Python eggs and `easy_install` behavior, which makes it very difficult to test modern compatibility with packages, and causes headaches in CI. To keep things manageable until we eventually move to `pyproject.toml`, this change brings over our standard `setup.py develop` override that forces usage of `pip`.	a62eb5992e0ffc95e2d8193adeb8f5f7d58f42b8

Issues

Description	From	Last Updated
Maybe change to "Installs the Review Bot extension in developer mode".	maubin	May 31, 2023, 3:27 p.m.

flake8 passed.

JSHint passed.

Ship it!

extension/setup.py (Diff revision 1)

Show all issues

Maybe change to "Installs the Review Bot extension in developer mode".

Change Summary:

Tweaked the docstring summary for the extension's DevelopCommand.

Commits:

	Summary	ID
	Update Review Bot to always use pip for developer mode. `setup.py develop` uses legacy Python eggs and `easy_install` behavior, which makes it very difficult to test modern compatibility with packages, and causes headaches in CI. To keep things manageable until we eventually move to `pyproject.toml`, this change brings over our standard `setup.py develop` override that forces usage of `pip`.	0ba4759c7bd17c8ba2155a20b70c91d410d1bc22
	Update Review Bot to always use pip for developer mode. `setup.py develop` uses legacy Python eggs and `easy_install` behavior, which makes it very difficult to test modern compatibility with packages, and causes headaches in CI. To keep things manageable until we eventually move to `pyproject.toml`, this change brings over our standard `setup.py develop` override that forces usage of `pip`.	a62eb5992e0ffc95e2d8193adeb8f5f7d58f42b8

Diff:

Revision 2 (+230)

Show changes

	bot/setup.py
	extension/setup.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (366faa2)