Summary

Move test fixtures out of conftest.py

Review Request #13076 — Created May 30, 2023 and submitted June 5, 2023, 9:26 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order to enable extensions to make use of pytest, we need our test
fixtures to be importable outside of the reviewboard source tree. This
change moves them into their own file and loads them from conftest.py

Testing Done

Ran unit tests.

Commits

Summary	ID
Move test fixtures out of conftest.py In order to enable extensions to make use of pytest, we need our test fixtures to be importable outside of the reviewboard source tree. This change moves them into their own file and loads them from conftest.py Testing Done: Ran unit tests	6b8e723d1086f0c3cec89eb40a228c126db53631

Issues

Description	From	Last Updated
Can we call this module pytest_fixtures, to differentiate from Django fixtures?	chipx86	May 31, 2023, 8:56 a.m.

flake8 passed.

JSHint passed.

conftest.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we call this module pytest_fixtures, to differentiate from Django fixtures?

Commits:

	Summary	ID
	Move test fixtures out of conftest.py In order to enable extensions to make use of pytest, we need our test fixtures to be importable outside of the reviewboard source tree. This change moves them into their own file and loads them from conftest.py Testing Done: Ran unit tests	f1bf6b6ee9a287e4288ff315ca3a1ab83b5661e2
	Move test fixtures out of conftest.py In order to enable extensions to make use of pytest, we need our test fixtures to be importable outside of the reviewboard source tree. This change moves them into their own file and loads them from conftest.py Testing Done: Ran unit tests	6b8e723d1086f0c3cec89eb40a228c126db53631

Diff:

Revision 2 (+206 -194)

Show changes

	conftest.py
	reviewboard/testing/pytest_fixtures.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (7d9e0ee)