Fix crashes when loading datagrids with ?sort=,

 






 

 


  Review Request #13072
  —
  Created May 25, 2023 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
We occasionally get error emails when web crawlers load datagrids with

poorly-formatted query parameters. Our own links will never try to load

?sort=,, but crawlers sometimes do. This change fixes it to properly

handle the situation where we have a non-empty sort string (",") but do

have empty sort parameters.

 








  


 
 

  
Loaded a dashboard with ?sort=, and saw that the page loaded instead

of creating a crash.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix crashes when loading datagrids with ?sort=,
      
We occasionally get error emails when web crawlers load datagrids with
poorly-formatted query parameters. Our own links will never try to load
`?sort=,`, but crawlers sometimes do. This change fixes it to properly
handle the situation where we have a non-empty sort string (",") but do
have empty sort parameters.

Testing Done:
Loaded a dashboard with `?sort=,` and saw that the page loaded instead
of creating a crash.

     


    		
    65aea08c29bf146cbd4288967cd3ef748c3f8d71

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-4.x (5564d02)





 


 










  

 









     

    

   

  

  

   
   Loading...