rbtools/postreview.py (Diff revision 1)
Would the local parent_branch parameter not be appropriate?
Fixing assumption that git master is svn trunk
Review Request #1307 — Created Dec. 22, 2009 and submitted
post-review assumes that master is tracking your svn trunk when the GitClient makes an svn diff, this patch uses the parent_branch instead of hard-coding master which fixes the issue when master is not the same as svn trunk.
This works well in my environment, there where no tests for this functionality.
Yes, parent branch will work for this case. To that end, I've amended the original patch.
Revision 2 (+1 -1)
Looks good, thanks! Committed as r7c2e318.