Summary

Switch from pkg_resources to importlib/packaging.

Review Request #13067 — Created May 25, 2023 and submitted May 30, 2023, 4:25 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

pkg_resources is deprecated, and not long for this world. To modernize
our code, we now use importlib (specifically, the importlib_metadata
and importlib_resources compatibility modules) and packaging.

These aren't one-to-one replacements for pkg_resources, but porting
was pretty minimal. For the purposes of RBTools, the new APIs give us
everything we need to look up entrypoints, fetch resource files, and
compare versions.

Testing Done

Tested running built-in RBTools commands, aliases, entrypoint-based
third-party commands, and commands in the search path starting with
rbt-.

Tested generating command line completion scripts.

Tested version parsing for all our flavors of version identifiers
provided throughout Review Board history (old-school 1.0alpha1
through modern 6.0b2).

Commits

Summary	ID
Switch from pkg_resources to importlib/packaging. `pkg_resources` is deprecated, and not long for this world. To modernize our code, we now use `importlib` (specifically, the `importlib_metadata` and `importlib_resources` compatibility modules) and `packaging`. These aren't one-to-one replacements for `pkg_resources`, but porting was pretty minimal. For the purposes of RBTools, the new APIs give us everything we need to look up entrypoints, fetch resource files, and compare versions.	9534a7351a12e3cf43f07ea2027d31c6ddf31440

Summary

Switch from pkg_resources to importlib/packaging.

`pkg_resources` is deprecated, and not long for this world. To modernize our code, we now use `importlib` (specifically, the `importlib_metadata` and `importlib_resources` compatibility modules) and `packaging`. These aren't one-to-one replacements for `pkg_resources`, but porting was pretty minimal. For the purposes of RBTools, the new APIs give us everything we need to look up entrypoints, fetch resource files, and compare versions.

9534a7351a12e3cf43f07ea2027d31c6ddf31440

Issues

Description	From	Last Updated
'typing.Iterable' imported but unused Column: 1 Error code: F401	reviewbot	May 25, 2023, 1:27 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Iterable' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Switch from pkg_resources to importlib/packaging. `pkg_resources` is deprecated, and not long for this world. To modernize our code, we now use `importlib` (specifically, the `importlib_metadata` and `importlib_resources` compatibility modules) and `packaging`. These aren't one-to-one replacements for `pkg_resources`, but porting was pretty minimal. For the purposes of RBTools, the new APIs give us everything we need to look up entrypoints, fetch resource files, and compare versions.	a16087f8b40b4d3c3c349a54ea116e5041e3cf4a
	Switch from pkg_resources to importlib/packaging. `pkg_resources` is deprecated, and not long for this world. To modernize our code, we now use `importlib` (specifically, the `importlib_metadata` and `importlib_resources` compatibility modules) and `packaging`. These aren't one-to-one replacements for `pkg_resources`, but porting was pretty minimal. For the purposes of RBTools, the new APIs give us everything we need to look up entrypoints, fetch resource files, and compare versions.	9534a7351a12e3cf43f07ea2027d31c6ddf31440

Diff:

Revision 2 (+226 -82)

Show changes

	setup.py
	rbtools/api/resource.py
	rbtools/commands/__init__.py
	rbtools/commands/main.py
	rbtools/commands/setup_completion.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (3fa65df)