Allow parsed ChangeSets to store extra_data on a draft.

 






 

 


  Review Request #13065
  —
  Created May 24, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
SCMTools that support pending changesets (Perforce, namely) can now set

extra_data fields on a review request draft. This is intended for

specializations of SCMTools for companies with additional requirements

for now, and may be exposed in a more general need later.


Like any extra_data fields, these will only be copied to the review

request on publish if there are custom review request fields registered.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Allow parsed ChangeSets to store extra_data on a draft.
     
SCMTools that support pending changesets (Perforce, namely) can now set
`extra_data` fields on a review request draft. This is intended for
specializations of SCMTools for companies with additional requirements
for now, and may be exposed in a more general need later.

Like any `extra_data` fields, these will only be copied to the review
request on publish if there are custom review request fields registered.

    

   
  		
  6c505925521dd08e180eb984c8afa9f19c25cfcb
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/models/review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/core.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...