Summary

Allow parsed ChangeSets to store extra_data on a draft.

Review Request #13065 — Created May 24, 2023 and submitted Aug. 7, 2023, 12:53 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

SCMTools that support pending changesets (Perforce, namely) can now set
extra_data fields on a review request draft. This is intended for
specializations of SCMTools for companies with additional requirements
for now, and may be exposed in a more general need later.

Like any extra_data fields, these will only be copied to the review
request on publish if there are custom review request fields registered.

Testing Done

Unit tests pass.

Commits

Summary	ID
Allow parsed ChangeSets to store extra_data on a draft. SCMTools that support pending changesets (Perforce, namely) can now set `extra_data` fields on a review request draft. This is intended for specializations of SCMTools for companies with additional requirements for now, and may be exposed in a more general need later. Like any `extra_data` fields, these will only be copied to the review request on publish if there are custom review request fields registered.	b5cd6db7e2368071baeeee9f9d81906762e20343

Summary

Allow parsed ChangeSets to store extra_data on a draft.

SCMTools that support pending changesets (Perforce, namely) can now set `extra_data` fields on a review request draft. This is intended for specializations of SCMTools for companies with additional requirements for now, and may be exposed in a more general need later. Like any `extra_data` fields, these will only be copied to the review request on publish if there are custom review request fields registered.

b5cd6db7e2368071baeeee9f9d81906762e20343

Issues

Description	From	Last Updated
This should be in the stdlib group.	david	Aug. 2, 2023, 1:47 a.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/models/review_request_draft.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be in the stdlib group.
```

Change Summary:


Fixed a bad import group.
Moved to release-6.x.

Commits:

	Summary	ID
	Allow parsed ChangeSets to store extra_data on a draft. SCMTools that support pending changesets (Perforce, namely) can now set `extra_data` fields on a review request draft. This is intended for specializations of SCMTools for companies with additional requirements for now, and may be exposed in a more general need later. Like any `extra_data` fields, these will only be copied to the review request on publish if there are custom review request fields registered.	6c505925521dd08e180eb984c8afa9f19c25cfcb
	Allow parsed ChangeSets to store extra_data on a draft. SCMTools that support pending changesets (Perforce, namely) can now set `extra_data` fields on a review request draft. This is intended for specializations of SCMTools for companies with additional requirements for now, and may be exposed in a more general need later. Like any `extra_data` fields, these will only be copied to the review request on publish if there are custom review request fields registered.	b5cd6db7e2368071baeeee9f9d81906762e20343

Branch:

-	release-5.0.x
+	release-6.x

Diff:

Revision 2 (+176 -50)

Show changes

	reviewboard/reviews/models/review_request_draft.py
	reviewboard/reviews/tests/test_review_request_draft.py
	reviewboard/scmtools/core.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9bd11a6)