Update TypedProperty usage to benefit from type hints.

Review Request #13063 — Created May 24, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

Djblets received support for type hints for TypedProperty. While
verbose, this allows us to ensure that the right values are going into
and coming out of these properties.

This updates all usage to incorporate typing, and adds typing
information for a few additional fields in some of the affected classes.

An argument could be made for switching away from TypedProperty in
time. However, it's still useful for ensuring strict types in key areas
like diff parsing and SCM results.

Unit tests pass.

Checked that pyright and mypy were happy.

Summary ID
Update TypedProperty usage to benefit from type hints.
Djblets received support for type hints for `TypedProperty`. While verbose, this allows us to ensure that the right values are going into and coming out of these properties. This updates all usage to incorporate typing, and adds typing information for a few additional fields in some of the affected classes. An argument could be made for switching away from `TypedProperty` in time. However, it's still useful for ensuring strict types in key areas like diff parsing and SCM results.
305c77dff7f1e91ab0f21fdfb347d2e835100e6b
Description From Last Updated

Can we make some aliases for some of these? I feel like this is very wordy.

daviddavid

too many blank lines (2) Column: 5 Error code: E303

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. reviewboard/diffviewer/parser.py (Diff revision 1)
     
     
     
    Show all issues

    Can we make some aliases for some of these? I feel like this is very wordy.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (0d17547)