Summary

Update TypedProperty usage to benefit from type hints.

Review Request #13063 — Created May 24, 2023 and submitted Aug. 7, 2023, 12:53 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Djblets received support for type hints for TypedProperty. While
verbose, this allows us to ensure that the right values are going into
and coming out of these properties.

This updates all usage to incorporate typing, and adds typing
information for a few additional fields in some of the affected classes.

An argument could be made for switching away from TypedProperty in
time. However, it's still useful for ensuring strict types in key areas
like diff parsing and SCM results.

Testing Done

Unit tests pass.

Checked that pyright and mypy were happy.

Commits

Summary	ID
Update TypedProperty usage to benefit from type hints. Djblets received support for type hints for `TypedProperty`. While verbose, this allows us to ensure that the right values are going into and coming out of these properties. This updates all usage to incorporate typing, and adds typing information for a few additional fields in some of the affected classes. An argument could be made for switching away from `TypedProperty` in time. However, it's still useful for ensuring strict types in key areas like diff parsing and SCM results.	305c77dff7f1e91ab0f21fdfb347d2e835100e6b

Summary

Update TypedProperty usage to benefit from type hints.

Djblets received support for type hints for `TypedProperty`. While verbose, this allows us to ensure that the right values are going into and coming out of these properties. This updates all usage to incorporate typing, and adds typing information for a few additional fields in some of the affected classes. An argument could be made for switching away from `TypedProperty` in time. However, it's still useful for ensuring strict types in key areas like diff parsing and SCM results.

305c77dff7f1e91ab0f21fdfb347d2e835100e6b

Issues

Description	From	Last Updated
Can we make some aliases for some of these? I feel like this is very wordy.	david	Aug. 2, 2023, 1:41 a.m.
too many blank lines (2) Column: 5 Error code: E303	reviewbot	Aug. 2, 2023, 1:41 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/core.py (Diff revision 1)

Show all issues

too many blank lines (2)

Column: 5
Error code: E303

reviewboard/diffviewer/parser.py (Diff revision 1)

Show all issues

Can we make some aliases for some of these? I feel like this is very wordy.

Change Summary:


Added internal type aliases for the various TypedProperty generics.
Moved this to release-6.x.

Commits:

	Summary	ID
	Update TypedProperty usage to benefit from type hints. Djblets received support for type hints for `TypedProperty`. While verbose, this allows us to ensure that the right values are going into and coming out of these properties. This updates all usage to incorporate typing, and adds typing information for a few additional fields in some of the affected classes. An argument could be made for switching away from `TypedProperty` in time. However, it's still useful for ensuring strict types in key areas like diff parsing and SCM results.	3957cf4871f978016584fd28a7ae94229f2d48ca
	Update TypedProperty usage to benefit from type hints. Djblets received support for type hints for `TypedProperty`. While verbose, this allows us to ensure that the right values are going into and coming out of these properties. This updates all usage to incorporate typing, and adds typing information for a few additional fields in some of the affected classes. An argument could be made for switching away from `TypedProperty` in time. However, it's still useful for ensuring strict types in key areas like diff parsing and SCM results.	305c77dff7f1e91ab0f21fdfb347d2e835100e6b

Branch:

-	release-5.0.x
+	release-6.x

Diff:

Revision 2 (+392 -132)

Show changes

	reviewboard/diffviewer/parser.py
	reviewboard/scmtools/core.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (0d17547)