Wrap .icon style to prevent cross-contamination.

 






 

 


  Review Request #13059
  —
  Created May 22, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Something changed in LESS that was causing our .icon() mixins to

cross-contaminate, meaning that some rules for defining .rb-icon-*

were also being duplicated as .datagrid-icon-*. This change wraps our

Review Board styles to ensure that the .icon() mixin stays in a very

limited scope.

 








  


 
 

  
Loaded the Review Board dashboard and saw that the datagrid icons were

no longer messed up.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Wrap .icon style to prevent cross-contamination.
     
Something changed in LESS that was causing our `.icon()` mixins to
cross-contaminate, meaning that some rules for defining `.rb-icon-*`
were also being duplicated as `.datagrid-icon-*`. This change wraps our
Review Board styles to ensure that the `.icon()` mixin stays in a very
limited scope.

Testing Done:
Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

    

   
  		
  926cd981c311aca1d214126029944df14305c687
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/css/assets/icons.less
     
    

   
  

 










     

    

   

  

  

   
   Loading...