flake8
passed.
JSHint
passed.
Review Request #13059 — Created May 22, 2023 and updated
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
Something changed in LESS that was causing our
.icon()
mixins to
cross-contaminate, meaning that some rules for defining.rb-icon-*
were also being duplicated as.datagrid-icon-*
. This change wraps our
Review Board styles to ensure that the.icon()
mixin stays in a very
limited scope.
Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
I made a similar comment to the Djblets side, but maybe we should call this .rb-icon() instead to avoid any … |
|
reviewboard/static/rb/css/assets/icons.less (Diff revision 1) |
---|
I made a similar comment to the Djblets side, but maybe we should call this
.rb-icon()
instead to avoid any namespacing issues anywhere.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+114 -116) |