Wrap .icon style to prevent cross-contamination.

Review Request #13059 — Created May 22, 2023 and updated

david
Review Board
release-6.x
reviewboard

Something changed in LESS that was causing our .icon() mixins to
cross-contaminate, meaning that some rules for defining .rb-icon-*
were also being duplicated as .datagrid-icon-*. This change wraps our
Review Board styles to ensure that the .icon() mixin stays in a very
limited scope.

Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

Summary
Wrap .icon style to prevent cross-contamination.
Description From Last Updated

I made a similar comment to the Djblets side, but maybe we should call this .rb-icon() instead to avoid any …

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/static/rb/css/assets/icons.less (Diff revision 1)
     
     
     
     
     
     
     
     
     

    I made a similar comment to the Djblets side, but maybe we should call this .rb-icon() instead to avoid any namespacing issues anywhere.

  3. 
      
david
Review request changed

Commits:

Summary
-
Wrap .icon style to prevent cross-contamination.
+
Wrap .icon style to prevent cross-contamination.

Diff:

Revision 2 (+114 -116)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...