Summary

Wrap .icon style to prevent cross-contamination.

Review Request #13059 — Created May 22, 2023 and submitted May 30, 2023, 11:54 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Something changed in LESS that was causing our .icon() mixins to
cross-contaminate, meaning that some rules for defining .rb-icon-*
were also being duplicated as .datagrid-icon-*. This change wraps our
Review Board styles to ensure that the .icon() mixin stays in a very
limited scope.

Testing Done

Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

Commits

Summary	ID
Wrap .icon style to prevent cross-contamination. Something changed in LESS that was causing our `.icon()` mixins to cross-contaminate, meaning that some rules for defining `.rb-icon-` were also being duplicated as `.datagrid-icon-`. This change wraps our Review Board styles to ensure that the `.icon()` mixin stays in a very limited scope. Testing Done: Loaded the Review Board dashboard and saw that the datagrid icons were no longer messed up.	adb11802ccf47fdc1b27d19a707ec670e59824c4

Summary

Wrap .icon style to prevent cross-contamination.

Something changed in LESS that was causing our `.icon()` mixins to cross-contaminate, meaning that some rules for defining `.rb-icon-*` were also being duplicated as `.datagrid-icon-*`. This change wraps our Review Board styles to ensure that the `.icon()` mixin stays in a very limited scope. Testing Done: Loaded the Review Board dashboard and saw that the datagrid icons were no longer messed up.

adb11802ccf47fdc1b27d19a707ec670e59824c4

Issues

Description	From	Last Updated
I made a similar comment to the Djblets side, but maybe we should call this .rb-icon() instead to avoid any …	chipx86	May 25, 2023, 9:31 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/assets/icons.less (Diff revision 1)

The issue has been resolved. Show all issues

I made a similar comment to the Djblets side, but maybe we should call this .rb-icon() instead to avoid any namespacing issues anywhere.

Commits:

	Summary	ID
	Wrap .icon style to prevent cross-contamination. Something changed in LESS that was causing our `.icon()` mixins to cross-contaminate, meaning that some rules for defining `.rb-icon-` were also being duplicated as `.datagrid-icon-`. This change wraps our Review Board styles to ensure that the `.icon()` mixin stays in a very limited scope. Testing Done: Loaded the Review Board dashboard and saw that the datagrid icons were no longer messed up.	926cd981c311aca1d214126029944df14305c687
	Wrap .icon style to prevent cross-contamination. Something changed in LESS that was causing our `.icon()` mixins to cross-contaminate, meaning that some rules for defining `.rb-icon-` were also being duplicated as `.datagrid-icon-`. This change wraps our Review Board styles to ensure that the `.icon()` mixin stays in a very limited scope. Testing Done: Loaded the Review Board dashboard and saw that the datagrid icons were no longer messed up.	adb11802ccf47fdc1b27d19a707ec670e59824c4

Diff:

Revision 2 (+114 -116)

Show changes

reviewboard/static/rb/css/assets/icons.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (0cced9f)