Summary:

Wrap .icon style to prevent cross-contamination.

Review Request #13058 — Created May 22, 2023 and submitted May 30, 2023, 11:53 a.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-4.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

Something changed in LESS that was causing our .icon() mixins to
cross-contaminate, meaning that some rules for defining .rb-icon-*
were also being duplicated as .datagrid-icon-*. This change wraps our
djblets styles to ensure that the .icon() mixin stays in a very
limited scope.

Testing Done

Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

Commits

Summary
	Wrap .icon style to prevent cross-contamination.

Screenshots

Issues

Description	From	Last Updated
I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().	chipx86	May 25, 2023, 9:22 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

djblets/static/djblets/css/datagrid.less (Diff revision 1)

Show all issues

I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().

Commits:

	Summary
-		Wrap .icon style to prevent cross-contamination.
+		Wrap .icon style to prevent cross-contamination.

Diff:

Revision 2 (+36 -32)

Show changes

djblets/static/djblets/css/datagrid.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (27e4f57)