flake8
passed.
JSHint
passed.
Review Request #13058 — Created May 22, 2023 and updated
Information | |
---|---|
david | |
Djblets | |
release-4.x | |
Reviewers | |
djblets | |
Something changed in LESS that was causing our
.icon()
mixins to
cross-contaminate, meaning that some rules for defining.rb-icon-*
were also being duplicated as.datagrid-icon-*
. This change wraps our
djblets styles to ensure that the.icon()
mixin stays in a very
limited scope.
Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon(). |
|
djblets/static/djblets/css/datagrid.less (Diff revision 1) |
---|
I think to be safest, what we should do is just rename
.icon()
to.djblets-datagrid-icon()
.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+36 -32) |