Wrap .icon style to prevent cross-contamination.

Review Request #13058 — Created May 22, 2023 and updated

david
Djblets
release-4.x
djblets

Something changed in LESS that was causing our .icon() mixins to
cross-contaminate, meaning that some rules for defining .rb-icon-*
were also being duplicated as .datagrid-icon-*. This change wraps our
djblets styles to ensure that the .icon() mixin stays in a very
limited scope.

Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

Summary
Wrap .icon style to prevent cross-contamination.
Description From Last Updated

I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. djblets/static/djblets/css/datagrid.less (Diff revision 1)
     
     
     

    I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().

  3. 
      
david
Review request changed

Commits:

Summary
-
Wrap .icon style to prevent cross-contamination.
+
Wrap .icon style to prevent cross-contamination.

Diff:

Revision 2 (+36 -32)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...