Wrap .icon style to prevent cross-contamination.

Review Request #13058 — Created May 22, 2023 and submitted

Information

Djblets
release-4.x

Reviewers

Something changed in LESS that was causing our .icon() mixins to
cross-contaminate, meaning that some rules for defining .rb-icon-*
were also being duplicated as .datagrid-icon-*. This change wraps our
djblets styles to ensure that the .icon() mixin stays in a very
limited scope.

Loaded the Review Board dashboard and saw that the datagrid icons were
no longer messed up.

Summary ID
Wrap .icon style to prevent cross-contamination.
Something changed in LESS that was causing our `.icon()` mixins to cross-contaminate, meaning that some rules for defining `.rb-icon-*` were also being duplicated as `.datagrid-icon-*`. This change wraps our djblets styles to ensure that the `.icon()` mixin stays in a very limited scope. Testing Done: Loaded the Review Board dashboard and saw that the datagrid icons were no longer messed up.
8c3bf97abf370e06e6dc46a69f3ad3d1b340f36c
Description From Last Updated

I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. djblets/static/djblets/css/datagrid.less (Diff revision 1)
     
     
     

    I think to be safest, what we should do is just rename .icon() to .djblets-datagrid-icon().

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (27e4f57)
Loading...