• 
      

    Don't reload the page when merely closing the review dialog.

    Review Request #13055 — Created May 19, 2023 and submitted — Latest diff uploaded

    Information

    Review Board
    release-6.x

    Reviewers

    We had recently added a change to explicitly reload the page after
    publishing reviews from the review dialog. This was done because with
    the new unified banner, we no longer had the post-publish trigger that
    was causing the reload. Unfortunately, this was also causing the page to
    reload when the "Close" button was clicked. This change fixes it so we
    only do it when publishing.

    Opened the review dialog, edited some comments, and then clicked
    "Close". Saw the review save and dialog close without the page
    reloading.

    Commits

    Files