Don't reload the page when merely closing the review dialog.

Review Request #13055 — Created May 19, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

We had recently added a change to explicitly reload the page after
publishing reviews from the review dialog. This was done because with
the new unified banner, we no longer had the post-publish trigger that
was causing the reload. Unfortunately, this was also causing the page to
reload when the "Close" button was clicked. This change fixes it so we
only do it when publishing.

Opened the review dialog, edited some comments, and then clicked
"Close". Saw the review save and dialog close without the page
reloading.

Summary ID
Don't reload the page when merely closing the review dialog.
We had recently added a change to explicitly reload the page after publishing reviews from the review dialog. This was done because with the new unified banner, we no longer had the post-publish trigger that was causing the reload. Unfortunately, this was also causing the page to reload when the "Close" button was clicked. This change fixes it so we only do it when publishing. Testing Done: Opened the review dialog, edited some comments, and then clicked "Close". Saw the review save and dialog close without the page reloading.
5ea95327243251525e4a85b1c70e699684a21458
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (467ed78)
Loading...