Fix minimum height of comment reply editors.

 






 

 


  Review Request #13054
  —
  Created May 18, 2023 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In the update to the review reply editors to switch to

InlineEditorView, I read the existing code a little bit wrong, and

mistakenly overrode the minimum height default to be zero. This change

removes that override, so that the default height for reply editors is

the default editor minimum (70px).

 








  


 
 

  
Opened editors for replies to comments and review headers and saw the

correct minimum editor height.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix minimum height of comment reply editors.
      
In the update to the review reply editors to switch to
`InlineEditorView`, I read the existing code a little bit wrong, and
mistakenly overrode the minimum height default to be zero. This change
removes that override, so that the default height for reply editors is
the default editor minimum (70px).

Testing Done:
Opened editors for replies to comments and review headers and saw the
correct minimum editor height.

     


    		
    3956d3c053add2daa26165dfd2da8987b1b120ef

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...